From: wessels <>
Date: Thu, 27 Apr 2006 22:54:16 +0000 (+0000)
Subject: Doug Dixon noticed in function handleIMSGiveClientUpdatedOldEntry()
X-Git-Tag: SQUID_3_0_PRE4~221
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=5b7a8f63c0b6e82f7e540e8b507f257cb11c32cf;p=thirdparty%2Fsquid.git

Doug Dixon noticed in function handleIMSGiveClientUpdatedOldEntry()
that the call to HTTPMSGLOCK is wrapped in an if statement, but the
call to HTTPMSGUNLOCK isn't, and that the unlink_request variable
is set but otherwise unused.  Probably a bug created by me in
revision 1.95, when converting to HTTPMSGUNLOCK macro.
---

diff --git a/src/client_side_reply.cc b/src/client_side_reply.cc
index 2de1b9bd5c..f54da21685 100644
--- a/src/client_side_reply.cc
+++ b/src/client_side_reply.cc
@@ -1,6 +1,6 @@
 
 /*
- * $Id: client_side_reply.cc,v 1.99 2006/02/26 13:43:05 serassio Exp $
+ * $Id: client_side_reply.cc,v 1.100 2006/04/27 16:54:16 wessels Exp $
  *
  * DEBUG: section 88    Client-side Reply Routines
  * AUTHOR: Robert Collins (Originally Duane Wessels in client_side.c)
@@ -440,7 +440,8 @@ clientReplyContext::handleIMSGiveClientUpdatedOldEntry()
 
         old_entry->timestamp = squid_curtime;
 
-        HTTPMSGUNLOCK(old_entry->mem_obj->request);
+        if (unlink_request)
+            HTTPMSGUNLOCK(old_entry->mem_obj->request);
     }
 
     sendClientOldEntry();