From: Frédéric Lécaille <flecaille@haproxy.com>
Date: Tue, 3 May 2022 13:55:17 +0000 (+0200)
Subject: BUG/MINOR: quic: Dropped peer transport parameters
X-Git-Tag: v2.6-dev10~57
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=5b988ebed1ebed47410de71bf87f919a4eba3319;p=thirdparty%2Fhaproxy.git

BUG/MINOR: quic: Dropped peer transport parameters

The call to quic_dflt_transport_params_cpy() is already first done by
quic_transport_params_init() which is a good thing. But this function was also
called each time we parsed a transport parameters with quic_transport_param_decode(),
re-initializing to default values some of them. The transport parameters concerned
by this bug are the following:
   - max_udp_payload_size
   - ack_delay_exponent
   - max_ack_delay
   - active_connection_id_limit
So, let's remove this call to quic_dflt_transport_params_cpy() which has nothing
to do here!
---

diff --git a/include/haproxy/xprt_quic.h b/include/haproxy/xprt_quic.h
index a61af090c3..6ff29b4cd5 100644
--- a/include/haproxy/xprt_quic.h
+++ b/include/haproxy/xprt_quic.h
@@ -607,7 +607,6 @@ static inline int quic_transport_param_decode(struct quic_transport_params *p,
 {
 	const unsigned char *end = *buf + len;
 
-	quic_dflt_transport_params_cpy(p);
 	switch (type) {
 	case QUIC_TP_ORIGINAL_DESTINATION_CONNECTION_ID:
 		if (!server || len >= sizeof p->original_destination_connection_id.data)