From: Yizhuo Date: Sun, 11 Jul 2021 20:23:32 +0000 (+0200) Subject: media: staging: atomisp: fix the uninitialized use in gc2235_detect() X-Git-Tag: v5.16-rc1~173^2~246 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=5ba9c067b5ed1ccfec58acae07c6582f16b9d44b;p=thirdparty%2Fkernel%2Flinux.git media: staging: atomisp: fix the uninitialized use in gc2235_detect() Inside function gc2235_detect(), variable "low" could be uninitialized if ov5693_read_reg() returns error, however, it affects the value of variable "id". The "id" is used in the later if statement, which is potentially unsafe. Link: https://lore.kernel.org/linux-media/20210711202334.27959-1-yzhai003@ucr.edu Signed-off-by: Yizhuo Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/staging/media/atomisp/i2c/ov5693/atomisp-ov5693.c b/drivers/staging/media/atomisp/i2c/ov5693/atomisp-ov5693.c index 5e3670c4fc29f..6c95f57a52e97 100644 --- a/drivers/staging/media/atomisp/i2c/ov5693/atomisp-ov5693.c +++ b/drivers/staging/media/atomisp/i2c/ov5693/atomisp-ov5693.c @@ -1714,6 +1714,8 @@ static int ov5693_detect(struct i2c_client *client) } ret = ov5693_read_reg(client, OV5693_8BIT, OV5693_SC_CMMN_CHIP_ID_L, &low); + if (ret) + return ret; id = ((((u16)high) << 8) | (u16)low); if (id != OV5693_ID) {