From: Paul Eggert <eggert@cs.ucla.edu>
Date: Wed, 19 Apr 2006 06:28:11 +0000 (+0000)
Subject: Change 'shred' to not use alloca.
X-Git-Tag: v6.0~465
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=5bbcc061d8c09d20c3c3ab3e8331cc2f71958b2f;p=thirdparty%2Fcoreutils.git

Change 'shred' to not use alloca.
---

diff --git a/ChangeLog b/ChangeLog
index e5ed89184f..e62718540d 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,7 +1,17 @@
-2006-04-18  Jim Meyering  <jim@meyering.net>
+2006-04-18  Paul Eggert  <eggert@cs.ucla.edu>
 
 	* Version 6.0-cvs.
 
+	* src/shred.c (fillrand): The assertion was way too weak, due to
+	what must be a typo.  Strengthen it to its intended value.
+	(dopass): Don't use alloca; it's not worth the aggravation here,
+	since it's used only to get a page-aligned buffer, and page
+	alignment doesn't buy us much here.  I'm suspicious that alloca
+	causes problems on some hosts, due to a recent bug report by Adam
+	Waltman.
+
+2006-04-18  Jim Meyering  <jim@meyering.net>
+
 	* tests/misc/tty-eof: Add new programs, base64, sha224sum, sha256sum,
 	sha384sum, sha512sum.