From: Alex Rousskov <rousskov@measurement-factory.com>
Date: Mon, 11 Apr 2011 23:49:57 +0000 (-0600)
Subject: Added TODOs to avoid creating unlocked store_table entries.
X-Git-Tag: take06~45
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=5bd484b5012e1b64baaee4cfb00a93b21f40c38c;p=thirdparty%2Fsquid.git

Added TODOs to avoid creating unlocked store_table entries.
---

diff --git a/src/neighbors.cc b/src/neighbors.cc
index d145a393cc..f9277309e7 100644
--- a/src/neighbors.cc
+++ b/src/neighbors.cc
@@ -1072,6 +1072,7 @@ neighborsUdpAck(const cache_key * key, icp_common_t * header, const Ip::Address
     }
 
     if (entry->lock_count == 0) {
+        // TODO: many entries are unlocked; why is this reported at level 1?
         debugs(12, 1, "neighborsUdpAck: '" << storeKeyText(key) << "' has no locks");
         neighborCountIgnored(p);
         return;
@@ -1817,6 +1818,7 @@ neighborsHtcpReply(const cache_key * key, htcpReplyData * htcp, const Ip::Addres
     }
 
     if (e->lock_count == 0) {
+        // TODO: many entries are unlocked; why is this reported at level 1?
         debugs(12, 1, "neighborsUdpAck: '" << storeKeyText(key) << "' has no locks");
         neighborCountIgnored(p);
         return;
diff --git a/src/urn.cc b/src/urn.cc
index 8e1c4ad714..48d35506d8 100644
--- a/src/urn.cc
+++ b/src/urn.cc
@@ -505,6 +505,8 @@ urnParseReply(const char *inbuf, const HttpRequestMethod& m)
 
         list[i].url = url;
         list[i].host = xstrdup(host);
+        // TODO: Use storeHas() or lock/unlock entry to avoid creating unlocked
+        // ones.
         list[i].flags.cached = storeGetPublic(url, m) ? 1 : 0;
         i++;
     }