From: Dan Carpenter Date: Sat, 8 Jun 2024 14:24:31 +0000 (+0300) Subject: ASoC: samsung: midas_wm1811: Fix error code in probe() X-Git-Tag: v6.11-rc1~108^2~6^2~115 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=5c33876a20e1f42471c2b6fd1804428311d35f1f;p=thirdparty%2Fkernel%2Flinux.git ASoC: samsung: midas_wm1811: Fix error code in probe() This accidentally returns success instead of -EINVAL. Fixes: c91d0c2e198d ("ASoC: samsung: midas_wm1811: Add GPIO-based headset jack detection") Signed-off-by: Dan Carpenter Acked-by: Artur Weber Link: https://lore.kernel.org/r/01590109-cf27-404b-88ff-b42bb73ca1c6@moroto.mountain Signed-off-by: Mark Brown --- diff --git a/sound/soc/samsung/midas_wm1811.c b/sound/soc/samsung/midas_wm1811.c index 3a269c7de1696..bbfe5fef59af1 100644 --- a/sound/soc/samsung/midas_wm1811.c +++ b/sound/soc/samsung/midas_wm1811.c @@ -623,7 +623,7 @@ static int midas_probe(struct platform_device *pdev) if (channel_type != IIO_VOLTAGE) { dev_err(dev, "ADC channel is not voltage\n"); - return ret; + return -EINVAL; } priv->gpio_headset_key = devm_gpiod_get(dev, "headset-key",