From: Chao Yu Date: Thu, 23 May 2024 13:29:48 +0000 (+0800) Subject: f2fs: fix to force buffered IO on inline_data inode X-Git-Tag: v6.11-rc1~60^2~20 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=5c8764f8679e;p=thirdparty%2Fkernel%2Flinux.git f2fs: fix to force buffered IO on inline_data inode It will return all zero data when DIO reading from inline_data inode, it is because f2fs_iomap_begin() assign iomap->type w/ IOMAP_HOLE incorrectly for this case. We can let iomap framework handle inline data via assigning iomap->type and iomap->inline_data correctly, however, it will be a little bit complicated when handling race case in between direct IO and buffered IO. So, let's force to use buffered IO to fix this issue. Cc: stable@vger.kernel.org Reported-by: Barry Song Signed-off-by: Chao Yu Signed-off-by: Jaegeuk Kim --- diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index 5c0b281a70f3e..0cbaeb97c7f52 100644 --- a/fs/f2fs/file.c +++ b/fs/f2fs/file.c @@ -825,6 +825,8 @@ static bool f2fs_force_buffered_io(struct inode *inode, int rw) return true; if (f2fs_compressed_file(inode)) return true; + if (f2fs_has_inline_data(inode)) + return true; /* disallow direct IO if any of devices has unaligned blksize */ if (f2fs_is_multi_device(sbi) && !sbi->aligned_blksize)