From: Marco Bettini Date: Tue, 23 Nov 2021 14:56:45 +0000 (+0100) Subject: acl: acl_mailbox_exists() - Add missing error handling X-Git-Tag: 2.3.18~113 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=5cf012bad9af616e2a137ca86e0625a841d01e68;p=thirdparty%2Fdovecot%2Fcore.git acl: acl_mailbox_exists() - Add missing error handling Set mailbox storage error to "internal error" when acl_object_get_my_rights() fails (as per contract). --- diff --git a/src/plugins/acl/acl-mailbox.c b/src/plugins/acl/acl-mailbox.c index 4208e2d1ae..134be7fecc 100644 --- a/src/plugins/acl/acl-mailbox.c +++ b/src/plugins/acl/acl-mailbox.c @@ -480,9 +480,10 @@ static int acl_mailbox_exists(struct mailbox *box, bool auto_boxes, const char *const *rights; unsigned int i; - if (acl_object_get_my_rights(abox->aclobj, pool_datastack_create(), - &rights) < 0) + if (acl_object_get_my_rights(abox->aclobj, pool_datastack_create(), &rights) < 0) { + mail_storage_set_internal_error(box->storage); return -1; + } /* for now this is used only by IMAP SUBSCRIBE. we'll intentionally violate RFC 4314 here, because it says SUBSCRIBE should succeed only