From: Vedran Furac <vedranf@haproxy.com>
Date: Wed, 16 Oct 2019 12:49:38 +0000 (+0200)
Subject: BUG/MINOR: server: check return value of fopen() in apply_server_state()
X-Git-Tag: v2.1-dev3~33
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=5d48627aba315a47589871c6fda83a4f07b23a71;p=thirdparty%2Fhaproxy.git

BUG/MINOR: server: check return value of fopen() in apply_server_state()

fopen() can return NULL when state file is missing. This patch adds a
check of fopen() return value so we can skip processing in such case.

No backport needed.
---

diff --git a/src/server.c b/src/server.c
index df0dcbfed7..6b740240ee 100644
--- a/src/server.c
+++ b/src/server.c
@@ -3595,6 +3595,8 @@ void apply_server_state(void)
 		f = fopen(globalfilepath, "r");
 		if (errno)
 			ha_warning("Can't open global server state file '%s': %s\n", globalfilepath, strerror(errno));
+		if (!f)
+			goto out_load_server_state_in_tree;
 
 		global_file_version = srv_state_get_version(f);
 		if (global_file_version == 0)