From: drh <>
Date: Fri, 10 May 2024 18:24:15 +0000 (+0000)
Subject: Fix aggregate function processing to correctly deal with OOMs inside of
X-Git-Tag: version-3.46.0~15
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=5d783d5c8490d1f115732e803152cf00b4ee4e15;p=thirdparty%2Fsqlite.git

Fix aggregate function processing to correctly deal with OOMs inside of
sqlite3ParserAddCleanup().
(dbsqlfuzz b2d11ca70e55ee8bde48ae0b53fa3e9355812f95).
Also add improved testing support by causing sqlite3FaultSim(300) to
simulate an OOM inside of sqlite3ParserAddCleanup() and by adding
improved fault-sim support to the CLI.

FossilOrigin-Name: c6fd70b3c23fa00eaac9286d4a67e5c8ac76f926c11c220250c34032647bedc1
---

5d783d5c8490d1f115732e803152cf00b4ee4e15
diff --cc manifest
index d73b846391,0baf00c3f8..eceb5d9184
--- a/manifest
+++ b/manifest
@@@ -1,5 -1,5 +1,5 @@@
- C Squelch\stwo\sOMIT-flag-related\swarnings\sreported\sin\s[forum:388243d9882067a9|forum\spost\s388243d9882067a9].\sNo\sfunctional\schanges.
- D 2024-05-10T09:26:53.619
 -C Add\sa\stest\sfor\sthe\sfixes\son\sthis\sbranch.
 -D 2024-05-10T18:15:03.688
++C Fix\saggregate\sfunction\sprocessing\sto\scorrectly\sdeal\swith\sOOMs\sinside\sof\nsqlite3ParserAddCleanup().\s\n(dbsqlfuzz\sb2d11ca70e55ee8bde48ae0b53fa3e9355812f95).\nAlso\sadd\simproved\stesting\ssupport\sby\scausing\ssqlite3FaultSim(300)\sto\nsimulate\san\sOOM\sinside\sof\ssqlite3ParserAddCleanup()\sand\sby\sadding\nimproved\sfault-sim\ssupport\sto\sthe\sCLI.
++D 2024-05-10T18:24:15.938
  F .fossil-settings/empty-dirs dbb81e8fc0401ac46a1491ab34a7f2c7c0452f2f06b54ebb845d024ca8283ef1
  F .fossil-settings/ignore-glob 35175cdfcf539b2318cb04a9901442804be81cd677d8b889fcc9149c21f239ea
  F LICENSE.md df5091916dbb40e6e9686186587125e1b2ff51f022cc334e886c19a0e9982724
@@@ -2189,8 -2190,8 +2190,9 @@@ F vsixtest/vsixtest.tcl 6a9a6ab600c25a9
  F vsixtest/vsixtest.vcxproj.data 2ed517e100c66dc455b492e1a33350c1b20fbcdc
  F vsixtest/vsixtest.vcxproj.filters 37e51ffedcdb064aad6ff33b6148725226cd608e
  F vsixtest/vsixtest_TemporaryKey.pfx e5b1b036facdb453873e7084e1cae9102ccc67a0
- P 857f5d7fadce1cfe30b3468826f403f736cfecacb1eb6d3b858b01ea3cfd6ffc
- R f270cbcd240352fa10729fed65c3c5a2
- U stephan
- Z 06aaa7e94b8e9b6ffd39f925ee912fbc
 -P c623d9a51e0ae6b4a8e1186714d14e7aa3df55246e123323481f07f07749dea5
++P 1d6716054d7fc50df237996c3db30e5fb8e32acbf48cb8b9af472360515945c4 716088d673b80446ea5f9cb83f6aad8a9ea2ec769d4894e02ab916930e4cf169
+ R 19835e40d33408ef0911b62a1ca97162
 -U dan
 -Z 94556ae52ccd512ae4690e06866d27a0
++T +closed 716088d673b80446ea5f9cb83f6aad8a9ea2ec769d4894e02ab916930e4cf169
++U drh
++Z 7c60328ccced7c5397c63b972a68b6fa
  # Remove this line to create a well-formed Fossil manifest.
diff --cc manifest.uuid
index a03c415635,465515fa0d..b3549e902d
--- a/manifest.uuid
+++ b/manifest.uuid
@@@ -1,1 -1,1 +1,1 @@@
- 1d6716054d7fc50df237996c3db30e5fb8e32acbf48cb8b9af472360515945c4
 -716088d673b80446ea5f9cb83f6aad8a9ea2ec769d4894e02ab916930e4cf169
++c6fd70b3c23fa00eaac9286d4a67e5c8ac76f926c11c220250c34032647bedc1