From: Magnus Hagander <magnus@hagander.net>
Date: Thu, 18 Mar 2021 10:24:42 +0000 (+0100)
Subject: Fix function name in error hint
X-Git-Tag: REL_11_12~57
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=5d825d7bee4d05c4ed086e23306e7a74b8f817a8;p=thirdparty%2Fpostgresql.git

Fix function name in error hint

pg_read_file() is the function that's in core, pg_file_read() is in
adminpack. But when using pg_file_read() in adminpack it calls the *C*
level function pg_read_file() in core, which probably threw the original
author off. But the error hint should be about the SQL function.

Reported-By: Sergei Kornilov
Backpatch-through: 11
Discussion: https://postgr.es/m/373021616060475@mail.yandex.ru
---

diff --git a/src/backend/utils/adt/genfile.c b/src/backend/utils/adt/genfile.c
index eaf4bcdcdcc..5a8c815b463 100644
--- a/src/backend/utils/adt/genfile.c
+++ b/src/backend/utils/adt/genfile.c
@@ -246,7 +246,7 @@ pg_read_file(PG_FUNCTION_ARGS)
 		ereport(ERROR,
 				(errcode(ERRCODE_INSUFFICIENT_PRIVILEGE),
 				 (errmsg("must be superuser to read files with adminpack 1.0"),
-				  errhint("Consider using pg_file_read(), which is part of core, instead."))));
+				  errhint("Consider using pg_read_file(), which is part of core, instead."))));
 
 	/* handle optional arguments */
 	if (PG_NARGS() >= 3)