From: Dan Carpenter Date: Wed, 15 Dec 2021 11:50:53 +0000 (+0300) Subject: iio: addac: ad74413r: fix off by one in ad74413r_parse_channel_config() X-Git-Tag: v5.17-rc1~82^2~40^2~29 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=5d97d9e9a703be2a602ac24c1ba3dae22155a2c8;p=thirdparty%2Fkernel%2Flinux.git iio: addac: ad74413r: fix off by one in ad74413r_parse_channel_config() The > needs to be >= to prevent accessing one element beyond the end of the st->channel_configs[] array. Fixes: fea251b6a5db ("iio: addac: add AD74413R driver") Signed-off-by: Dan Carpenter Reviewed-by: Cosmin Tanislav Signed-off-by: Jonathan Cameron --- diff --git a/drivers/iio/addac/ad74413r.c b/drivers/iio/addac/ad74413r.c index cbd9aa9b399a2..289d254943e16 100644 --- a/drivers/iio/addac/ad74413r.c +++ b/drivers/iio/addac/ad74413r.c @@ -1150,7 +1150,7 @@ static int ad74413r_parse_channel_config(struct iio_dev *indio_dev, return ret; } - if (index > AD74413R_CHANNEL_MAX) { + if (index >= AD74413R_CHANNEL_MAX) { dev_err(st->dev, "Channel index %u is too large\n", index); return -EINVAL; }