From: Thomas Markwalder <tmark@isc.org>
Date: Thu, 6 Jun 2019 17:31:08 +0000 (-0400)
Subject: [#16,!9] Addressed review comments
X-Git-Tag: v4_4_2b1~19^2~1
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=5df5813d20c9fe323357ed72b5db9a79dc269fce;p=thirdparty%2Fdhcp.git

[#16,!9] Addressed review comments

Added comments on #endif statements
---

diff --git a/client/dhclient.c b/client/dhclient.c
index 313394f3e..6828c6766 100644
--- a/client/dhclient.c
+++ b/client/dhclient.c
@@ -123,7 +123,8 @@ static int check_option_values(struct universe *universe, unsigned int opt,
 #if defined(NSUPDATE)
 static void dhclient_ddns_cb_free(dhcp_ddns_cb_t *ddns_cb,
                                    char* file, int line);
-#endif
+#endif /* defined NSUPDATE */
+
 
 /*!
  *
@@ -1575,7 +1576,8 @@ void bind_lease (client)
 #if defined (NSUPDATE)
 	if (client->config->do_forward_update)
 		dhclient_schedule_updates(client, &client->active->address, 1);
-#endif
+#endif /* defined NSUPDATE */
+
 }
 
 /* state_bound is called when we've successfully bound to a particular
@@ -4801,7 +4803,8 @@ client_dns_remove(struct client_state *client,
 		}
 	}
 }
-#endif
+#endif /* defined NSUPDATE */
+
 
 isc_result_t dhcp_set_control_state (control_object_state_t oldstate,
 				     control_object_state_t newstate)
@@ -4842,7 +4845,8 @@ isc_result_t dhcp_set_control_state (control_object_state_t oldstate,
 				    client_dns_remove(client,
 						      &client->active->address);
 			    }
-#endif
+#endif /* defined NSUPDATE */
+
 			    do_release (client);
 		    }
 		    break;
@@ -5189,7 +5193,7 @@ dhclient_schedule_updates(struct client_state *client,
 			  piaddr(*addr));
 	}
 }
-#endif
+#endif /* defined NSUPDATE */
 
 void
 dhcpv4_client_assignments(void)
@@ -5398,7 +5402,7 @@ dhclient_ddns_cb_free(dhcp_ddns_cb_t *ddns_cb, char* file, int line) {
         ddns_cb_free(ddns_cb, file, line);
     }
 }
-#endif
+#endif /* defined NSUPDATE */
 
 #if defined(DHCPv6) && defined(DHCP4o6)
 /*
diff --git a/includes/omapip/isclib.h b/includes/omapip/isclib.h
index 7c8078637..a93117c9c 100644
--- a/includes/omapip/isclib.h
+++ b/includes/omapip/isclib.h
@@ -143,6 +143,7 @@ extern int shutdown_signal;
 
 #if defined (NSUPDATE)
 isc_result_t dns_client_init();
-#endif
+#endif /* defined NSUPDATE */
+
 
 #endif /* ISCLIB_H */