From: William Dauchy Date: Sun, 25 Oct 2020 13:01:33 +0000 (+0100) Subject: CLEANUP: http_ana: remove unused assignation of `att_beg` X-Git-Tag: v2.3-dev9~27 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=5e10e44bce78677e2d8ccfc5e8be33fb2c6a6011;p=thirdparty%2Fhaproxy.git CLEANUP: http_ana: remove unused assignation of `att_beg` `att_beg` is assigned to `next` at the end of the `for` loop, but is assigned to `prev` at the beginning of the loop, which is itself assigned to `next` after each loop. So it represents a double assignation for the same value. Also `att_beg` is not used after the end of the loop. this is a partial fix for github issue #923, all the others could probably be marked as intentional to protect future changes. no backport needed. Signed-off-by: William Dauchy --- diff --git a/src/http_ana.c b/src/http_ana.c index f2edc681f9..c2080bf9a7 100644 --- a/src/http_ana.c +++ b/src/http_ana.c @@ -3533,8 +3533,6 @@ static void http_manage_client_side_cookies(struct stream *s, struct channel *re } } - /* continue with next cookie on this header line */ - att_beg = next; } /* for each cookie */