From: Razvan Becheriu Date: Tue, 20 May 2025 04:48:32 +0000 (+0300) Subject: [#3833] addressed review comments X-Git-Tag: Kea-2.7.9~10 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=5e21953fb907c3ea5a4ecf03070937d69734394b;p=thirdparty%2Fkea.git [#3833] addressed review comments --- diff --git a/doc/sphinx/arm/agent.rst b/doc/sphinx/arm/agent.rst index 4f36196565..b6c58e0265 100644 --- a/doc/sphinx/arm/agent.rst +++ b/doc/sphinx/arm/agent.rst @@ -154,7 +154,7 @@ specified for the DHCPv4, DHCPv6, and D2 services. As of Kea 2.7.9, control sockets may only reside in the directory determined during compilation as ``"[kea-install-dir]/var/run/kea"``, - which must also have ``750`` access rights. This path may be overridden + which must also have ``0750`` access rights. This path may be overridden at startup by setting the environment variable ``KEA_CONTROL_SOCKET_DIR`` to the desired path. If a path other than this value is used in ``socket-name``, Kea will emit an error and refuse to start or, if already diff --git a/doc/sphinx/arm/ddns.rst b/doc/sphinx/arm/ddns.rst index d3077096a9..384a2dd44a 100644 --- a/doc/sphinx/arm/ddns.rst +++ b/doc/sphinx/arm/ddns.rst @@ -328,7 +328,7 @@ Kea supports only one ``unix`` control socket in the "control-sockets" list. As of Kea 2.7.9, control sockets may only reside in the directory determined during compilation as ``"[kea-install-dir]/var/run/kea"``, - which must also have ``750`` access rights. This path may be overridden + which must also have ``0750`` access rights. This path may be overridden at startup by setting the environment variable ``KEA_CONTROL_SOCKET_DIR`` to the desired path. If a path other than this value is used in ``socket-name``, Kea will emit an error and refuse to start or, if already diff --git a/doc/sphinx/arm/dhcp4-srv.rst b/doc/sphinx/arm/dhcp4-srv.rst index 72624b4526..d6ff2b3edd 100644 --- a/doc/sphinx/arm/dhcp4-srv.rst +++ b/doc/sphinx/arm/dhcp4-srv.rst @@ -7840,7 +7840,7 @@ Kea supports only one ``unix`` control socket in the "control-sockets" list. As of Kea 2.7.9, control sockets may only reside in the directory determined during compilation as ``"[kea-install-dir]/var/run/kea"``, - which must also have ``750`` access rights. This path may be overridden + which must also have ``0750`` access rights. This path may be overridden at startup by setting the environment variable ``KEA_CONTROL_SOCKET_DIR`` to the desired path. If a path other than this value is used in ``socket-name``, Kea will emit an error and refuse to start or, if already diff --git a/doc/sphinx/arm/dhcp6-srv.rst b/doc/sphinx/arm/dhcp6-srv.rst index 43fb308453..b2a89d0529 100644 --- a/doc/sphinx/arm/dhcp6-srv.rst +++ b/doc/sphinx/arm/dhcp6-srv.rst @@ -7746,7 +7746,7 @@ Kea supports only one ``unix`` control socket in the "control-sockets" list. As of Kea 2.7.9, control sockets may only reside in the directory determined during compilation as ``"[kea-install-dir]/var/run/kea"``, - which must also have ``750`` access rights. This path may be overridden + which must also have ``0750`` access rights. This path may be overridden at startup by setting the environment variable ``KEA_CONTROL_SOCKET_DIR`` to the desired path. If a path other than this value is used in ``socket-name``, Kea will emit an error and refuse to start or, if already diff --git a/doc/sphinx/arm/security.rst b/doc/sphinx/arm/security.rst index 75786a04a2..6ad9aace3e 100644 --- a/doc/sphinx/arm/security.rst +++ b/doc/sphinx/arm/security.rst @@ -39,8 +39,9 @@ protection possible: .. note:: It is recommend to use privileged ports for HTTP/HTTPS against local attacks - (users which are conencted to the box where Kea servers/agents run). This measure - also prevents against impersonation with HTTP and DoS in general. + (by users which are connected to the box where Kea servers/agents run). This + measure also prevents against impersonation with HTTP and Denial of Service in + general. .. note:: @@ -328,7 +329,7 @@ file-access control on POSIX systems (owner, group, others, read/write). As of Kea 2.7.9, control sockets may only reside in the directory determined during compilation as ``"[kea-install-dir]/var/run/kea"``, - which must also have ``750`` access rights. This path may be overridden + which must also have ``0750`` access rights. This path may be overridden at startup by setting the environment variable ``KEA_CONTROL_SOCKET_DIR`` to the desired path. If a path other than this value is used in ``socket-name``, Kea will emit an error and refuse to start or, if already @@ -500,8 +501,8 @@ using basic HTTP authentication. Kea 1.9.2 introduced a new ``auth`` hook point. With this new hook point, it is possible to develop an external hook library to extend the access controls, integrate with another authentication authority, or add role-based -access control to the Control Agent. This hookpoint is also supported by the DHCP and DDNS servers since Kea -version 2.7.2. +access control to the Control Agent. This hookpoint was renamed as ``http_auth`` and is also supported by the DHCP +and DDNS servers since Kea version 2.7.2. .. note: diff --git a/src/lib/util/filesystem.cc b/src/lib/util/filesystem.cc index dc90bbf1d1..fd65e7bcb5 100644 --- a/src/lib/util/filesystem.cc +++ b/src/lib/util/filesystem.cc @@ -10,7 +10,6 @@ #include #include -#include #include #include #include diff --git a/src/lib/util/filesystem.h b/src/lib/util/filesystem.h index 09e953599c..8147d8c5b7 100644 --- a/src/lib/util/filesystem.h +++ b/src/lib/util/filesystem.h @@ -7,7 +7,7 @@ #ifndef KEA_UTIL_FILESYSTEM_H #define KEA_UTIL_FILESYSTEM_H -#include +#include #include #include