From: Vivek Trivedi <t.vivek@samsung.com>
Date: Sun, 20 Dec 2015 23:54:39 +0000 (+1100)
Subject: xfs_db: remove unnessary checks in process_leaf_node_dir_v2_free
X-Git-Tag: v4.5.0-rc1~54
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=5e2918c2cfc4db04e827f9e1ca8c8441ab45c9f7;p=thirdparty%2Fxfsprogs-dev.git

xfs_db: remove unnessary checks in process_leaf_node_dir_v2_free

xfs_dir2_free_hdr_t entries are unsigned, so they can't be negative.
remove these unnessary checks in process_leaf_node_dir_v2_free.
Reported by coverity.

Signed-off-by: Vivek Trivedi <t.vivek@samsung.com>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
---

diff --git a/db/check.c b/db/check.c
index f1620f863..341a83c4c 100644
--- a/db/check.c
+++ b/db/check.c
@@ -3073,9 +3073,7 @@ process_leaf_node_dir_v3_free(
 		return;
 	}
 	if (be32_to_cpu(free->hdr.nvalid) > maxent || 
-				be32_to_cpu(free->hdr.nvalid) < 0 ||
 				be32_to_cpu(free->hdr.nused) > maxent || 
-				be32_to_cpu(free->hdr.nused) < 0 ||
 				be32_to_cpu(free->hdr.nused) > 
 					be32_to_cpu(free->hdr.nvalid)) {
 		if (!sflag || v)