From: Derrick Stolee Date: Tue, 1 Oct 2024 17:37:44 +0000 (+0000) Subject: read-cache: free threaded memory pool X-Git-Tag: v2.47.0~11^2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=5e6f359f6b7829e3baea888f5489f04eebf745af;p=thirdparty%2Fgit.git read-cache: free threaded memory pool In load_cache_entries_threaded(), each thread allocates its own memory pool. This pool needs to be cleaned up while closing the threads down, or it will be leaked. This ce_mem_pool pointer could theoretically be converted to an inline copy of the struct, but the use of a pointer helps with existing lazy- initialization logic. Adjusting that behavior only to avoid this pointer would be a much bigger change. Signed-off-by: Derrick Stolee Signed-off-by: Junio C Hamano --- diff --git a/read-cache.c b/read-cache.c index 48bf24f87c..3b76a1f5d5 100644 --- a/read-cache.c +++ b/read-cache.c @@ -2187,6 +2187,7 @@ static unsigned long load_cache_entries_threaded(struct index_state *istate, con if (err) die(_("unable to join load_cache_entries thread: %s"), strerror(err)); mem_pool_combine(istate->ce_mem_pool, p->ce_mem_pool); + free(p->ce_mem_pool); consumed += p->consumed; }