From: Ilya Shipitsin <chipitsine@gmail.com>
Date: Thu, 18 May 2023 21:21:39 +0000 (+0200)
Subject: src/openvpn/dco_freebsd.c: handle malloc failure
X-Git-Tag: v2.7_alpha1~463
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=5e79aed439d4e1b101c768aabfd695cd1c0a54ce;p=thirdparty%2Fopenvpn.git

src/openvpn/dco_freebsd.c: handle malloc failure

malloc was not checked against NULL, I was able
to get core dump in case of failure

Signed-off-by: Ilya Shipitsin <chipitsine@gmail.com>
Acked-by: Gert Doering <gert@greenie.muc.de>
Message-Id: <20230518212139.1261-1-chipitsine@gmail.com>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg26707.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
---

diff --git a/src/openvpn/dco_freebsd.c b/src/openvpn/dco_freebsd.c
index 1111abebd..af7776bb8 100644
--- a/src/openvpn/dco_freebsd.c
+++ b/src/openvpn/dco_freebsd.c
@@ -594,6 +594,10 @@ dco_available(int msglevel)
     }
 
     buf = malloc(ifcr.ifcr_total * IFNAMSIZ);
+    if (!buf)
+    {
+        goto out;
+    }
 
     ifcr.ifcr_count = ifcr.ifcr_total;
     ifcr.ifcr_buffer = buf;