From: Patrick Palka <ppalka@redhat.com>
Date: Fri, 13 Jun 2025 15:03:19 +0000 (-0400)
Subject: libstdc++: Optimize __make_comp/pred_proj for empty/scalar types
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=5e8168a659ecc63804984d20365b4df401d9675b;p=thirdparty%2Fgcc.git

libstdc++: Optimize __make_comp/pred_proj for empty/scalar types

When creating a composite comparator/predicate that invokes a given
projection function, we don't need to capture a scalar (such as a
function pointer or member pointer) or empty object by reference,
instead capture it by value and use [[no_unique_address]] to elide
its storage (in the empty case).  This makes using __make_comp_proj
zero-cost in the common case where both functions are empty/scalars.

libstdc++-v3/ChangeLog:

	* include/bits/ranges_algo.h (__detail::__by_ref_or_value_fn): New.
	(__detail::_Comp_proj): New.
	(__detail::__make_comp_proj): Use it instead.
	(__detail::_Pred_proj): New.
	(__detail::__make_pred_proj): Use it instead.

Reviewed-by: Tomasz Kamiński <tkaminsk@redhat.com>
Reviewed-by: Jonathan Wakely <jwakely@redhat.com>
---

diff --git a/libstdc++-v3/include/bits/ranges_algo.h b/libstdc++-v3/include/bits/ranges_algo.h
index a62c3cd3954..5aca6e8d864 100644
--- a/libstdc++-v3/include/bits/ranges_algo.h
+++ b/libstdc++-v3/include/bits/ranges_algo.h
@@ -47,28 +47,60 @@ namespace ranges
 {
   namespace __detail
   {
+    template<typename _Fp>
+      using __by_ref_or_value_fn
+	= __conditional_t<is_scalar_v<_Fp> || is_empty_v<_Fp>, _Fp, _Fp&>;
+
     template<typename _Comp, typename _Proj>
-      constexpr auto
+      struct _Comp_proj
+      {
+	[[no_unique_address]] __by_ref_or_value_fn<_Comp> _M_comp;
+	[[no_unique_address]] __by_ref_or_value_fn<_Proj> _M_proj;
+
+	constexpr
+	_Comp_proj(_Comp& __comp, _Proj& __proj)
+	: _M_comp(__comp), _M_proj(__proj)
+	{ }
+
+	template<typename _Tp, typename _Up>
+	  constexpr bool
+	  operator()(_Tp&& __x, _Up&& __y)
+	  {
+	    return std::__invoke(_M_comp,
+				 std::__invoke(_M_proj, std::forward<_Tp>(__x)),
+				 std::__invoke(_M_proj, std::forward<_Up>(__y)));
+	  }
+      };
+
+    template<typename _Comp, typename _Proj>
+      constexpr _Comp_proj<_Comp, _Proj>
       __make_comp_proj(_Comp& __comp, _Proj& __proj)
+      { return {__comp, __proj}; }
+
+    template<typename _Pred, typename _Proj>
+      struct _Pred_proj
       {
-	return [&] (auto&& __lhs, auto&& __rhs) -> bool {
-	  using _TL = decltype(__lhs);
-	  using _TR = decltype(__rhs);
-	  return std::__invoke(__comp,
-			       std::__invoke(__proj, std::forward<_TL>(__lhs)),
-			       std::__invoke(__proj, std::forward<_TR>(__rhs)));
-	};
-      }
+	[[no_unique_address]] __by_ref_or_value_fn<_Pred> _M_pred;
+	[[no_unique_address]] __by_ref_or_value_fn<_Proj> _M_proj;
+
+	constexpr
+	_Pred_proj(_Pred& __pred, _Proj& __proj)
+	: _M_pred(__pred), _M_proj(__proj)
+	{ }
+
+	template<typename _Tp>
+	  constexpr bool
+	  operator()(_Tp&& __x)
+	  {
+	    return std::__invoke(_M_pred,
+				 std::__invoke(_M_proj, std::forward<_Tp>(__x)));
+	  }
+      };
 
     template<typename _Pred, typename _Proj>
-      constexpr auto
+      constexpr _Pred_proj<_Pred, _Proj>
       __make_pred_proj(_Pred& __pred, _Proj& __proj)
-      {
-	return [&] <typename _Tp> (_Tp&& __arg) -> bool {
-	  return std::__invoke(__pred,
-			       std::__invoke(__proj, std::forward<_Tp>(__arg)));
-	};
-      }
+      { return {__pred, __proj}; }
   } // namespace __detail
 
   struct __all_of_fn