From: Krzysztof Kozlowski Date: Fri, 16 Aug 2024 10:54:37 +0000 (+0200) Subject: memory: ti-aemif: simplify with scoped for each OF child loop X-Git-Tag: v6.12-rc1~187^2~24^2~9 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=5e8431f722d95bf58276a3051240c1ebe3cc238d;p=thirdparty%2Fkernel%2Flinux.git memory: ti-aemif: simplify with scoped for each OF child loop Use scoped for_each_available_child_of_node_scoped() when iterating over device nodes to make code a bit simpler. Reviewed-by: Jonathan Cameron Link: https://lore.kernel.org/r/20240816-cleanup-h-of-node-put-memory-v2-13-9eed0ee16b78@linaro.org Signed-off-by: Krzysztof Kozlowski --- diff --git a/drivers/memory/ti-aemif.c b/drivers/memory/ti-aemif.c index a1f1922ea2912..3b546eddf5fe9 100644 --- a/drivers/memory/ti-aemif.c +++ b/drivers/memory/ti-aemif.c @@ -329,7 +329,6 @@ static int aemif_probe(struct platform_device *pdev) int ret = -ENODEV; struct device *dev = &pdev->dev; struct device_node *np = dev->of_node; - struct device_node *child_np; struct aemif_device *aemif; aemif = devm_kzalloc(dev, sizeof(*aemif), GFP_KERNEL); @@ -359,12 +358,10 @@ static int aemif_probe(struct platform_device *pdev) * functions iterate over these nodes and update the cs data * array. */ - for_each_available_child_of_node(np, child_np) { + for_each_available_child_of_node_scoped(np, child_np) { ret = of_aemif_parse_abus_config(pdev, child_np); - if (ret < 0) { - of_node_put(child_np); + if (ret < 0) return ret; - } } }