From: Wolfram Sang Date: Tue, 7 Jan 2025 09:02:03 +0000 (+0100) Subject: i3c: cdns: use parity8 helper instead of open coding it X-Git-Tag: v6.14-rc1~98^2~2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=5e8c732357ce0abe6251120d65f1ddbe5bc939fd;p=thirdparty%2Fkernel%2Flinux.git i3c: cdns: use parity8 helper instead of open coding it The kernel has now a generic helper for getting parity with easier to understand semantics. Make use of it. Signed-off-by: Wolfram Sang Link: https://lore.kernel.org/r/20250107090204.6593-6-wsa+renesas@sang-engineering.com Signed-off-by: Alexandre Belloni --- diff --git a/drivers/i3c/master/i3c-master-cdns.c b/drivers/i3c/master/i3c-master-cdns.c index fe4d59833ad5f..8d69a34986d96 100644 --- a/drivers/i3c/master/i3c-master-cdns.c +++ b/drivers/i3c/master/i3c-master-cdns.c @@ -889,8 +889,7 @@ static u32 prepare_rr0_dev_address(u32 addr) ret |= (addr & GENMASK(9, 7)) << 6; /* RR0[0] = ~XOR(addr[6:0]) */ - if (!(hweight8(addr & 0x7f) & 1)) - ret |= 1; + ret |= parity8(addr & 0x7f) ? 0 : BIT(0); return ret; }