From: Eric Wong <e@80x24.org>
Date: Sat, 8 Feb 2025 03:26:38 +0000 (+0000)
Subject: qspawn: drop redundant check against limiter->{max}
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=5ec3189273664348b49ce7c48d7c5aacb90b6f6a;p=thirdparty%2Fpublic-inbox.git

qspawn: drop redundant check against limiter->{max}

We only need to guard against excessive parallelism on entry
in one place during Qspawn->start.  Redundant guards are
confusing and make bugs harder-to-spot.
---

diff --git a/lib/PublicInbox/Qspawn.pm b/lib/PublicInbox/Qspawn.pm
index 9bd225b78..34e9eff69 100644
--- a/lib/PublicInbox/Qspawn.pm
+++ b/lib/PublicInbox/Qspawn.pm
@@ -107,13 +107,9 @@ sub finalize ($) {
 
 	# process is done, spawn whatever's in the queue
 	my $limiter = delete $self->{limiter} or return;
-	my $running = --$limiter->{running};
-
-	if ($running < $limiter->{max}) {
-		if (my $next = shift(@{$limiter->{run_queue}})) {
-			_do_spawn(@$next, $limiter);
-		}
-	}
+	--$limiter->{running};
+	my $next = shift @{$limiter->{run_queue}};
+	_do_spawn(@$next, $limiter) if $next;
 	_finalize $self;
 }