From: Cosmin Tanislav <demonsingur@gmail.com>
Date: Wed, 7 May 2025 12:19:10 +0000 (+0300)
Subject: i2c: atr: do not create mapping in detach_addr()
X-Git-Tag: v6.16-rc1~112^2~6
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=5efe815ad7355655f3a6ce9593530afd6ecc6d21;p=thirdparty%2Flinux.git

i2c: atr: do not create mapping in detach_addr()

It is useless to create a new mapping just to detach it immediately.

Use the newly added i2c_atr_find_mapping_by_addr() function to avoid it,
and exit without logging an error if not found.

Signed-off-by: Cosmin Tanislav <demonsingur@gmail.com>
Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---

diff --git a/drivers/i2c/i2c-atr.c b/drivers/i2c/i2c-atr.c
index 7e70ac6c0976e..5f08445ce0a35 100644
--- a/drivers/i2c/i2c-atr.c
+++ b/drivers/i2c/i2c-atr.c
@@ -586,10 +586,8 @@ static void i2c_atr_detach_addr(struct i2c_adapter *adapter,
 
 	mutex_lock(&chan->alias_pairs_lock);
 
-	c2a = i2c_atr_get_mapping_by_addr(chan, addr);
+	c2a = i2c_atr_find_mapping_by_addr(chan, addr);
 	if (!c2a) {
-		 /* This should never happen */
-		dev_warn(atr->dev, "Unable to find address mapping\n");
 		mutex_unlock(&chan->alias_pairs_lock);
 		return;
 	}