From: Amir Goldstein Date: Tue, 29 Aug 2023 13:25:47 +0000 (+0300) Subject: ovl: propagate IOCB_APPEND flag on writes to realfile X-Git-Tag: v6.7-rc1~49^2~16 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=5f034d34737e8c440bbbd13e5ef283793d841140;p=thirdparty%2Fkernel%2Flinux.git ovl: propagate IOCB_APPEND flag on writes to realfile If ovl file is opened O_APPEND, the underlying realfile is also opened O_APPEND, so it makes sense to propagate the IOCB_APPEND flags on sync writes to realfile, just as we do with aio writes. Effectively, because sync ovl writes are protected by inode lock, this change only makes a difference if the realfile is written to (size extending writes) from underneath overlayfs. The behavior in this case is undefined, so it is ok if we change the behavior (to fail the ovl IOCB_APPEND write). Signed-off-by: Amir Goldstein --- diff --git a/fs/overlayfs/file.c b/fs/overlayfs/file.c index 4dccef12a33a8..32eb90713ff8e 100644 --- a/fs/overlayfs/file.c +++ b/fs/overlayfs/file.c @@ -264,7 +264,7 @@ static void ovl_file_accessed(struct file *file) } #define OVL_IOCB_MASK \ - (IOCB_NOWAIT | IOCB_HIPRI | IOCB_DSYNC | IOCB_SYNC) + (IOCB_NOWAIT | IOCB_HIPRI | IOCB_DSYNC | IOCB_SYNC | IOCB_APPEND) static rwf_t iocb_to_rw_flags(int flags) {