From: Fangrui Song <maskray@google.com>
Date: Mon, 13 Sep 2021 19:39:20 +0000 (-0700)
Subject: configure: Fix check for INSERT in linker script
X-Git-Tag: glibc-2.35~524
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=5f07d47e4b3d137edfbe3ea6c4eeba1ea6cfa54d;p=thirdparty%2Fglibc.git

configure: Fix check for INSERT in linker script

GCC/Clang use local access when referencing a const variable,
so the conftest.so may have no dynamic relocation.
LLD reports `error: unable to insert .foo after .rela.dyn` when the
destination section does not exist.

Use a non-const int to ensure that .rela.dyn exists.

Reviewed-by: Siddhesh Poyarekar <siddhesh@sourceware.org>
---

diff --git a/configure b/configure
index 542802ad356..39d75eb4edc 100755
--- a/configure
+++ b/configure
@@ -5793,7 +5793,7 @@ if ${libc_cv_insert+:} false; then :
   $as_echo_n "(cached) " >&6
 else
   cat > conftest.c <<EOF
-		const int __attribute__ ((section(".bar"))) bar = 0x12345678;
+		int __attribute__ ((section(".bar"))) bar = 0x12345678;
 		int test (void) { return bar; }
 EOF
 		cat > conftest.t <<EOF
diff --git a/configure.ac b/configure.ac
index d9232418de5..00f49f09f70 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1217,7 +1217,7 @@ AC_SUBST(libc_cv_protected_data)
 AC_CACHE_CHECK(linker support for INSERT in linker script,
 	       libc_cv_insert,
 	       [cat > conftest.c <<EOF
-		const int __attribute__ ((section(".bar"))) bar = 0x12345678;
+		int __attribute__ ((section(".bar"))) bar = 0x12345678;
 		int test (void) { return bar; }
 EOF
 		cat > conftest.t <<EOF