From: Masahiro Yamada Date: Fri, 22 Sep 2017 03:46:46 +0000 (+0900) Subject: mtd: nand: denali: use upper/lower_32_bits() macro for clean-up X-Git-Tag: v4.15-rc1~25^2~14^2~23 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=5f2baae00542b2203e6d0fa77890f64ff741aaf3;p=thirdparty%2Fkernel%2Flinux.git mtd: nand: denali: use upper/lower_32_bits() macro for clean-up I used (uint64_t) cast to avoid "right shift count >= width of type" warning. provides nice helpers to cater to it. The code will be cleaner, and easier to understand. Signed-off-by: Masahiro Yamada Signed-off-by: Boris Brezillon --- diff --git a/drivers/mtd/nand/denali.c b/drivers/mtd/nand/denali.c index 02ce310f44e4e..e567ad9a4ef34 100644 --- a/drivers/mtd/nand/denali.c +++ b/drivers/mtd/nand/denali.c @@ -469,10 +469,10 @@ static void denali_setup_dma64(struct denali_nand_info *denali, 0x01002000 | (64 << 16) | (write << 8) | page_count); /* 2. set memory low address */ - denali_host_write(denali, mode, dma_addr); + denali_host_write(denali, mode, lower_32_bits(dma_addr)); /* 3. set memory high address */ - denali_host_write(denali, mode, (uint64_t)dma_addr >> 32); + denali_host_write(denali, mode, upper_32_bits(dma_addr)); } static void denali_setup_dma32(struct denali_nand_info *denali,