From: Razvan Becheriu <razvan@isc.org>
Date: Wed, 28 Jun 2023 15:40:36 +0000 (+0300)
Subject: [#2831] addressed review comments
X-Git-Tag: Kea-2.4.0~40
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=5f4c51e30da96096ba19961da04352520a940de3;p=thirdparty%2Fkea.git

[#2831] addressed review comments
---

diff --git a/src/bin/perfdhcp/command_options.cc b/src/bin/perfdhcp/command_options.cc
index 66e557814c..fa6772e60d 100644
--- a/src/bin/perfdhcp/command_options.cc
+++ b/src/bin/perfdhcp/command_options.cc
@@ -602,7 +602,7 @@ CommandOptions::initialize(int argc, char** argv, bool print_cmd_line) {
             } else if (optarg_text == "avalanche") {
                 scenario_ = Scenario::AVALANCHE;
             } else {
-                isc_throw(InvalidParameter, "scenario value '" << optarg << "' is wrong - should be 'basic' or 'avalanche'");
+                isc_throw(InvalidParameter, "scenario value '" << optarg_text << "' is wrong - should be 'basic' or 'avalanche'");
             }
             break;
         }
diff --git a/src/lib/dns/nsec3hash.cc b/src/lib/dns/nsec3hash.cc
index 64030ff62a..279a2bd562 100644
--- a/src/lib/dns/nsec3hash.cc
+++ b/src/lib/dns/nsec3hash.cc
@@ -62,15 +62,14 @@ public:
                      const uint8_t* salt_data, size_t salt_length) :
         algorithm_(algorithm), iterations_(iterations),
         salt_data_(NULL), salt_length_(salt_length),
-        digest_(DEFAULT_DIGEST_LENGTH), obuf_(Name::MAX_WIRE)
-    {
+        digest_(DEFAULT_DIGEST_LENGTH), obuf_(Name::MAX_WIRE) {
         if (algorithm_ != NSEC3_HASH_SHA1) {
             isc_throw(UnknownNSEC3HashAlgorithm, "Unknown NSEC3 algorithm: " <<
                       static_cast<unsigned int>(algorithm_));
         }
 
         if (salt_data == NULL) {
-            isc_throw(BadValue, "salt data is NULL");
+            isc_throw(isc::BadValue, "salt data is NULL");
         }
 
         if (salt_length > 0) {