From: Patrick Steinhardt <ps@pks.im>
Date: Tue, 5 Nov 2024 06:16:43 +0000 (+0100)
Subject: builtin/ls-remote: plug leaking server options
X-Git-Tag: v2.48.0-rc0~65^2~21
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=5f5dd8e297b59f3f7bf61098e978a91c5581388a;p=thirdparty%2Fgit.git

builtin/ls-remote: plug leaking server options

The list of server options populated via `OPT_STRING_LIST()` is never
cleared, causing a memory leak. Plug it.

This leak is exposed by t5702, but plugging it alone does not make the
whole test suite pass.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/builtin/ls-remote.c b/builtin/ls-remote.c
index 423318f87e..42f34e1236 100644
--- a/builtin/ls-remote.c
+++ b/builtin/ls-remote.c
@@ -166,6 +166,7 @@ int cmd_ls_remote(int argc,
 		status = 0; /* we found something */
 	}
 
+	string_list_clear(&server_options, 0);
 	ref_sorting_release(sorting);
 	ref_array_clear(&ref_array);
 	if (transport_disconnect(transport))