From: Alejandro Colomar <alx@kernel.org>
Date: Wed, 11 Dec 2024 20:16:13 +0000 (+0100)
Subject: lib/fields.c: valid_field(): Return early on error
X-Git-Tag: 4.18.0-rc1~36
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=5f8349bc0b4424e46bc217d9e983e9e4ca1e01aa;p=thirdparty%2Fshadow.git

lib/fields.c: valid_field(): Return early on error

Signed-off-by: Alejandro Colomar <alx@kernel.org>
---

diff --git a/lib/fields.c b/lib/fields.c
index 818d1c593..625a8f588 100644
--- a/lib/fields.c
+++ b/lib/fields.c
@@ -48,13 +48,11 @@ valid_field_(const char *field, const char *illegal)
 	/* Search if there are non-printable or control characters */
 	for (cp = field; !streq(cp, ""); cp++) {
 		unsigned char c = *cp;
+		if (iscntrl(c))
+			return -1;
 		if (!isprint (c)) {
 			err = 1;
 		}
-		if (iscntrl (c)) {
-			err = -1;
-			break;
-		}
 	}
 
 	return err;