From: hno <>
Date: Mon, 9 May 2005 23:11:57 +0000 (+0000)
Subject: Bug #1229: Random data corruption / lost whitespace characters.
X-Git-Tag: SQUID_3_0_PRE4~758
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=5fa061b85ef225925d945b5a77f88ad63b0a325e;p=thirdparty%2Fsquid.git

Bug #1229: Random data corruption / lost whitespace characters.

This patch both corrects the whitespace delete between replies and
deactivates it entirely as this breaks certain HTTP/0.9 replies.

The response splitting counter measures is extremely likely to trigger
on this anyway, killing the connection before it may be reused (still
need to be forward-ported from Squid-2.5).
---

diff --git a/src/http.cc b/src/http.cc
index 5577cc692f..d27ee1c353 100644
--- a/src/http.cc
+++ b/src/http.cc
@@ -1,6 +1,6 @@
 
 /*
- * $Id: http.cc,v 1.449 2005/04/03 18:53:24 serassio Exp $
+ * $Id: http.cc,v 1.450 2005/05/09 17:11:57 hno Exp $
  *
  * DEBUG: section 11    Hypertext Transfer Protocol (HTTP)
  * AUTHOR: Harvest Derived
@@ -979,10 +979,16 @@ HttpStateData::readReply (int fd, char *readBuf, size_t len, comm_err_t flag, in
         IOStats.Http.read_hist[bin]++;
     }
 
-    if (!memBufIsNull(&reply_hdr) && flag == COMM_OK && len > 0 && fd_table[fd].uses > 1) {
-        /* Skip whitespace */
+    /* here the RFC says we should ignore whitespace between replies, but we can't as
+     * doing so breaks HTTP/0.9 replies beginning with witespace, and in addition
+     * the response splitting countermeasures is extremely likely to trigger on this,
+     * not allowing connection reuse in the first place.
+     */
+#if DONT_DO_THIS
+    if (reply_hdr_state == 0 && flag == COMM_OK && len > 0 && fd_table[fd].uses > 1) {
+        /* Skip whitespace between replies */
 
-        while (len > 0 && xisspace(*buf))
+        while (len > 0 && isspace(*buf))
             xmemmove(buf, buf + 1, len--);
 
         if (len == 0) {
@@ -994,6 +1000,8 @@ HttpStateData::readReply (int fd, char *readBuf, size_t len, comm_err_t flag, in
         }
     }
 
+#endif
+
     if (flag != COMM_OK || len < 0) {
         debug(50, 2) ("httpReadReply: FD %d: read failure: %s.\n",
                       fd, xstrerror());