From: Timo Sirainen <timo.sirainen@open-xchange.com>
Date: Mon, 1 Mar 2021 14:47:54 +0000 (+0200)
Subject: pop3: Improve "inactivity" disconnection reason log messages
X-Git-Tag: 2.3.15~268
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=5fb3a030d79095bd4e1c6926e7d18a15e88e1ac4;p=thirdparty%2Fdovecot%2Fcore.git

pop3: Improve "inactivity" disconnection reason log messages
---

diff --git a/src/pop3/pop3-client.c b/src/pop3/pop3-client.c
index 36dedc1c55..e5021d4d81 100644
--- a/src/pop3/pop3-client.c
+++ b/src/pop3/pop3-client.c
@@ -75,11 +75,14 @@ static void client_commit_timeout(struct client *client)
 static void client_idle_timeout(struct client *client)
 {
 	if (client->cmd != NULL) {
-		client_destroy(client,
-			"Disconnected for inactivity in reading our output");
+		client_destroy(client, t_strdup_printf(
+			"Client has not read server output for for %"PRIdTIME_T" secs",
+			ioloop_time - client->last_output));
 	} else {
 		client_send_line(client, "-ERR Disconnected for inactivity.");
-		client_destroy(client, "Disconnected for inactivity");
+		client_destroy(client, t_strdup_printf(
+			"Inactivity - no input for %"PRIdTIME_T" secs",
+			ioloop_time - client->last_input));
 	}
 }