From: Aki Tuomi <aki.tuomi@open-xchange.com>
Date: Thu, 16 Jan 2025 13:39:34 +0000 (+0200)
Subject: auth: userdb sql - Fail if iterate_query is not set
X-Git-Tag: 2.4.0~43
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=5fb53d39cd0af1b3c5b4ff8a79c7a3c2a215ff48;p=thirdparty%2Fdovecot%2Fcore.git

auth: userdb sql - Fail if iterate_query is not set

Otherwise we end up with panic.
---

diff --git a/src/auth/userdb-sql.c b/src/auth/userdb-sql.c
index 576076044d..c508193392 100644
--- a/src/auth/userdb-sql.c
+++ b/src/auth/userdb-sql.c
@@ -187,8 +187,14 @@ userdb_sql_iterate_init(struct auth_request *auth_request,
 		return &ctx->ctx;
 	}
 
-	sql_query(module->db, set->iterate_query, sql_iter_query_callback, ctx);
-	e_debug(authdb_event(auth_request), "%s", set->iterate_query);
+	if (*set->iterate_query == '\0') {
+		e_error(authdb_event(auth_request), "User iteration failed: "
+			"userdb_sql_iterate_query is empty");
+		ctx->ctx.failed = TRUE;
+	} else {
+		sql_query(module->db, set->iterate_query, sql_iter_query_callback, ctx);
+		e_debug(authdb_event(auth_request), "%s", set->iterate_query);
+	}
 	settings_free(set);
 	return &ctx->ctx;
 }