From: Yang Yingliang <yangyingliang@huawei.com>
Date: Fri, 24 Apr 2020 08:03:48 +0000 (+0800)
Subject: ptp: idt82p33: remove unnecessary comparison
X-Git-Tag: v5.8-rc1~165^2~432
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=6033cebdfff9b10192eb254e8cc60fedd595ea7f;p=thirdparty%2Fkernel%2Flinux.git

ptp: idt82p33: remove unnecessary comparison

The type of loaddr is u8 which is always '<=' 0xff, so the
loaddr <= 0xff is always true, we can remove this comparison.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/ptp/ptp_idt82p33.c b/drivers/ptp/ptp_idt82p33.c
index 31ea811b6d5f2..179f6c472e500 100644
--- a/drivers/ptp/ptp_idt82p33.c
+++ b/drivers/ptp/ptp_idt82p33.c
@@ -881,7 +881,7 @@ static int idt82p33_load_firmware(struct idt82p33 *idt82p33)
 
 			/* Page size 128, last 4 bytes of page skipped */
 			if (((loaddr > 0x7b) && (loaddr <= 0x7f))
-			     || ((loaddr > 0xfb) && (loaddr <= 0xff)))
+			     || loaddr > 0xfb)
 				continue;
 
 			err = idt82p33_write(idt82p33, _ADDR(page, loaddr),