From: Eric Wong <e@80x24.org>
Date: Sun, 26 Mar 2023 23:48:03 +0000 (+0000)
Subject: git: check for --version errors
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=6061f4e7b3c68bb4f41960c4df2c1eddcbdc86d9;p=thirdparty%2Fpublic-inbox.git

git: check for --version errors

While unlikely, `git --version' may fail, so we must check for
errors and by reaping the process ASAP via tied close().
---

diff --git a/lib/PublicInbox/Git.pm b/lib/PublicInbox/Git.pm
index 2729b38fd..6f8232cfd 100644
--- a/lib/PublicInbox/Git.pm
+++ b/lib/PublicInbox/Git.pm
@@ -64,6 +64,7 @@ sub check_git_exe () {
 	if ($st ne $EXE_ST) {
 		my $rd = popen_rd([ $GIT_EXE, '--version' ]);
 		my $v = readline($rd);
+		close($rd) or die "$GIT_EXE --version: $?";
 		$v =~ /\b([0-9]+(?:\.[0-9]+){2})/ or die
 			"$GIT_EXE --version output: $v # unparseable";
 		my @v = split(/\./, $1, 3);