From: Jeff Davis <jdavis@postgresql.org>
Date: Mon, 18 Mar 2024 22:34:43 +0000 (-0700)
Subject: Fix another warning, introduced by 846311051e.
X-Git-Tag: REL_17_BETA1~599
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=60769c62dc85680ee357aec92461fe97c715aebb;p=thirdparty%2Fpostgresql.git

Fix another warning, introduced by 846311051e.

Discussion: https://postgr.es/m/3703896.1710799495@sss.pgh.pa.us
Reported-by: Tom Lane
---

diff --git a/src/backend/utils/adt/pg_locale.c b/src/backend/utils/adt/pg_locale.c
index f793f50b984..3f311e99076 100644
--- a/src/backend/utils/adt/pg_locale.c
+++ b/src/backend/utils/adt/pg_locale.c
@@ -2505,13 +2505,13 @@ pg_strnxfrm_prefix(char *dest, size_t destsize, const char *src,
 int
 builtin_locale_encoding(const char *locale)
 {
-	if (strcmp(locale, "C") == 0)
-		return -1;
-	else
+	if (strcmp(locale, "C") != 0)
 		ereport(ERROR,
 				(errcode(ERRCODE_WRONG_OBJECT_TYPE),
 				 errmsg("invalid locale name \"%s\" for builtin provider",
 						locale)));
+
+	return -1;
 }