From: Junio C Hamano Date: Thu, 27 Jan 2022 19:02:58 +0000 (-0800) Subject: CodingGuidelines: hint why we value clearly written log messages X-Git-Tag: v2.36.0-rc0~162^2~1 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=607817a3c8d2992f69e53c42dfa604b59d1570ba;p=thirdparty%2Fgit.git CodingGuidelines: hint why we value clearly written log messages Signed-off-by: Junio C Hamano --- diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines index 0e27b5395d..c37c43186e 100644 --- a/Documentation/CodingGuidelines +++ b/Documentation/CodingGuidelines @@ -26,6 +26,13 @@ code. For Git in general, a few rough rules are: go and fix it up." Cf. http://lkml.iu.edu/hypermail/linux/kernel/1001.3/01069.html + - Log messages to explain your changes are as important as the + changes themselves. Clearly written code and in-code comments + explain how the code works and what is assumed from the surrounding + context. The log messages explain what the changes wanted to + achieve and why the changes were necessary (more on this in the + accompanying SubmittingPatches document). + Make your code readable and sensible, and don't try to be clever. As for more concrete guidelines, just imitate the existing code