From: Nicolas Vigier Date: Mon, 30 Sep 2013 14:46:14 +0000 (+0200) Subject: git-svn: fix signed commit parsing X-Git-Tag: v1.8.5-rc0~48^2~6 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=60786bd41a575126c0735c55b46e1d0ee2b358cc;p=thirdparty%2Fgit.git git-svn: fix signed commit parsing When parsing a commit object, git-svn wrongly think that a line containing spaces means the end of headers and the start of the commit message. In case of signed commit, the gpgsig entry contains a line with one space, so "git svn dcommit" will include part of the signature in the commit message. An example of such problem : http://svnweb.mageia.org/treasurer?view=revision&revision=86 This commit changes the regex to only match an empty line as separator between the headers and the commit message. Signed-off-by: Nicolas Vigier Reviewed-by: Jonathan Nieder Signed-off-by: Eric Wong --- diff --git a/git-svn.perl b/git-svn.perl index ff1ce3d351..1823db135e 100755 --- a/git-svn.perl +++ b/git-svn.perl @@ -1759,7 +1759,7 @@ sub get_commit_entry { my $msgbuf = ""; while (<$msg_fh>) { if (!$in_msg) { - $in_msg = 1 if (/^\s*$/); + $in_msg = 1 if (/^$/); $author = $1 if (/^author (.*>)/); } elsif (/^git-svn-id: /) { # skip this for now, we regenerate the