From: Stefan Schantl <stefan.schantl@ipfire.org>
Date: Sun, 18 Oct 2015 12:25:50 +0000 (+0200)
Subject: pppsetup.cgi: Fix site layout when no TYPE is specified
X-Git-Tag: v2.17-core95~49
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=609b862fe7c58c3d61244888c1f7a98cb7da66cb;p=people%2Fstevee%2Fipfire-2.x.git

pppsetup.cgi: Fix site layout when no TYPE is specified

There was an issue with false generated HTML code, in case
of an empty or unset $pppsettings{'TYPE'} variable which results
in a missplaced website footer.

This patch moves the code for closeing the table and the call of the
closebox() function to the correct place to prevent this display issue.

Fixes #10565.

Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org>
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
---

diff --git a/html/cgi-bin/pppsetup.cgi b/html/cgi-bin/pppsetup.cgi
index b3e8e6c006..36d0ced90d 100644
--- a/html/cgi-bin/pppsetup.cgi
+++ b/html/cgi-bin/pppsetup.cgi
@@ -980,12 +980,14 @@ print <<END
         <td colspan='2' width='50%'>$Lang::tr{'legend'}:</td>
         <td colspan='2' width='50%'><img src='/blob.gif' alt='*' />&nbsp;$Lang::tr{'required field'}</td>
 </tr>
-</table>
 END
 ;
-&Header::closebox();
 }
 
+print "</table>";
+
+&Header::closebox();
+
 print "</form>\n";
 
 &Header::closebigbox();