From: Arindam Nath Date: Wed, 5 Feb 2020 15:54:25 +0000 (+0530) Subject: NTB: handle link down event correctly X-Git-Tag: v5.7-rc1~147^2~7 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=60ceafd151d62eba6c19c27e617269567082a17d;p=thirdparty%2Flinux.git NTB: handle link down event correctly Link-Up and Link-Down are mutually exclusive events. So when we receive a Link-Down event, we should also clear the bitmask for Link-Up event in peer_sta. Signed-off-by: Arindam Nath Signed-off-by: Jon Mason --- diff --git a/drivers/ntb/hw/amd/ntb_hw_amd.c b/drivers/ntb/hw/amd/ntb_hw_amd.c index e964442ae2c35..d933a1dffdc68 100644 --- a/drivers/ntb/hw/amd/ntb_hw_amd.c +++ b/drivers/ntb/hw/amd/ntb_hw_amd.c @@ -551,8 +551,12 @@ static void amd_handle_event(struct amd_ntb_dev *ndev, int vec) dev_info(dev, "Flush is done.\n"); break; case AMD_PEER_RESET_EVENT: - ndev->peer_sta |= AMD_PEER_RESET_EVENT; - amd_ack_smu(ndev, AMD_PEER_RESET_EVENT); + case AMD_LINK_DOWN_EVENT: + ndev->peer_sta |= status; + if (status == AMD_LINK_DOWN_EVENT) + ndev->peer_sta &= ~AMD_LINK_UP_EVENT; + + amd_ack_smu(ndev, status); /* link down first */ ntb_link_event(&ndev->ntb); @@ -563,7 +567,6 @@ static void amd_handle_event(struct amd_ntb_dev *ndev, int vec) case AMD_PEER_D3_EVENT: case AMD_PEER_PMETO_EVENT: case AMD_LINK_UP_EVENT: - case AMD_LINK_DOWN_EVENT: ndev->peer_sta |= status; amd_ack_smu(ndev, status);