From: Eric W. Biederman <ebiederm@xmission.com>
Date: Sun, 26 Apr 2020 12:51:03 +0000 (-0500)
Subject: exec: Remove BUG_ON(has_group_leader_pid)
X-Git-Tag: v5.8-rc1~145^2~3^2~1
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=610b818856e1477964b59040c740f6ec55883045;p=thirdparty%2Fkernel%2Flinux.git

exec: Remove BUG_ON(has_group_leader_pid)

With the introduction of exchange_tids thread_group_leader and
has_group_leader_pid have become equivalent.  Further at this point in the
code a thread group has exactly two threads, the previous thread_group_leader
that is waiting to be reaped and tsk.  So we know it is impossible for tsk to
be the thread_group_leader.

This is also the last user of has_group_leader_pid so removing this check
will allow has_group_leader_pid to be removed.

So remove the "BUG_ON(has_group_leader_pid)" that will never fire.

Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
---

diff --git a/fs/exec.c b/fs/exec.c
index 9b60f927afd7d..6ab1c19d84faf 100644
--- a/fs/exec.c
+++ b/fs/exec.c
@@ -1176,7 +1176,6 @@ static int de_thread(struct task_struct *tsk)
 		tsk->start_boottime = leader->start_boottime;
 
 		BUG_ON(!same_thread_group(leader, tsk));
-		BUG_ON(has_group_leader_pid(tsk));
 		/*
 		 * An exec() starts a new thread group with the
 		 * TGID of the previous thread group. Rehash the