From: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Date: Wed, 29 May 2024 10:47:41 +0000 (+0200)
Subject: basic/fd-util: drop report from fd_cloexec_many
X-Git-Tag: v257-rc1~1189^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=613b698eb45f733645a5a9ba1b497c6c76c7868b;p=thirdparty%2Fsystemd.git

basic/fd-util: drop report from fd_cloexec_many

fd_cloexec_many promised to report if work was done, but that code was
not effective, because it always reported true if any fds were open.
But no callers care about the return value, so let's just drop this.
---

diff --git a/src/basic/fd-util.c b/src/basic/fd-util.c
index f9cac3d99e9..c33cc6f783b 100644
--- a/src/basic/fd-util.c
+++ b/src/basic/fd-util.c
@@ -212,9 +212,6 @@ int fd_cloexec_many(const int fds[], size_t n_fds, bool cloexec) {
                         continue;
 
                 RET_GATHER(r, fd_cloexec(*fd, cloexec));
-
-                if (r >= 0)
-                        r = 1; /* report if we did anything */
         }
 
         return r;