From: Mike Bayer <mike_mp@zzzcomputing.com>
Date: Tue, 10 Jun 2025 21:33:14 +0000 (-0400)
Subject: use integer division on maxlen
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=61477cf8b8af2b5a7123764a564da056f1a5c999;p=thirdparty%2Fsqlalchemy%2Fsqlalchemy.git

use integer division on maxlen

this was coming out as a float and breaking alembic column
compare

Change-Id: I50160cfdb2f2933331d3c316c9985f24fb914242
---

diff --git a/lib/sqlalchemy/dialects/mssql/base.py b/lib/sqlalchemy/dialects/mssql/base.py
index a71042a3f0..c0bf43304a 100644
--- a/lib/sqlalchemy/dialects/mssql/base.py
+++ b/lib/sqlalchemy/dialects/mssql/base.py
@@ -3738,7 +3738,7 @@ where
                 MSNChar,
                 MSNText,
             ):
-                kwargs["length"] = maxlen / 2 if maxlen != -1 else None
+                kwargs["length"] = maxlen // 2 if maxlen != -1 else None
                 if collation:
                     kwargs["collation"] = collation
 
diff --git a/lib/sqlalchemy/testing/suite/test_reflection.py b/lib/sqlalchemy/testing/suite/test_reflection.py
index efb2ad505c..aa1a4e90a8 100644
--- a/lib/sqlalchemy/testing/suite/test_reflection.py
+++ b/lib/sqlalchemy/testing/suite/test_reflection.py
@@ -2871,6 +2871,7 @@ class ComponentReflectionTestExtra(ComparesIndexes, fixtures.TestBase):
             assert isinstance(typ, sql_types.String)
 
         eq_(typ.length, 52)
+        assert isinstance(typ.length, int)
 
     @testing.requires.table_reflection
     def test_nullable_reflection(self, connection, metadata):