From: Gregory CLEMENT Date: Fri, 13 Jul 2018 10:27:26 +0000 (+0200) Subject: clk: mvebu: armada-37xx-periph: Fix wrong return value in get_parent X-Git-Tag: v4.19-rc1~130^2~2^6~1 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=616bf80d381da13fbb392ebff06f46f946e3ee84;p=thirdparty%2Flinux.git clk: mvebu: armada-37xx-periph: Fix wrong return value in get_parent The return value of the get_parent operation is a u8, whereas a -EINVAL was returned. This wrong value was return if the value was bigger that the number of parent but this case was already handled by the core. So we can just remove this chunk of code to fix the issue. Reported-by: Dan Carpenter Fixes: 9818a7a4fd10 ("clk: mvebu: armada-37xx-periph: prepare cpu clk to be used with DVFS") Signed-off-by: Gregory CLEMENT Signed-off-by: Stephen Boyd --- diff --git a/drivers/clk/mvebu/armada-37xx-periph.c b/drivers/clk/mvebu/armada-37xx-periph.c index 6860bd5a37c5e..5cf0a52b87e8a 100644 --- a/drivers/clk/mvebu/armada-37xx-periph.c +++ b/drivers/clk/mvebu/armada-37xx-periph.c @@ -428,9 +428,6 @@ static u8 clk_pm_cpu_get_parent(struct clk_hw *hw) val &= pm_cpu->mask_mux; } - if (val >= num_parents) - return -EINVAL; - return val; }