From: Greg Kroah-Hartman Date: Mon, 8 May 2017 07:43:12 +0000 (+0200) Subject: 4.4-stable patches X-Git-Tag: v4.4.68~46 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=61ab992f2761161db8e4ce699d547b94d488cf2d;p=thirdparty%2Fkernel%2Fstable-queue.git 4.4-stable patches added patches: 9p-fix-a-potential-acl-leak.patch --- diff --git a/queue-4.4/9p-fix-a-potential-acl-leak.patch b/queue-4.4/9p-fix-a-potential-acl-leak.patch new file mode 100644 index 00000000000..b95bc7c2fe6 --- /dev/null +++ b/queue-4.4/9p-fix-a-potential-acl-leak.patch @@ -0,0 +1,48 @@ +From b5c66bab72a6a65edb15beb60b90d3cb84c5763b Mon Sep 17 00:00:00 2001 +From: Cong Wang +Date: Wed, 22 Feb 2017 15:40:53 -0800 +Subject: 9p: fix a potential acl leak + +From: Cong Wang + +commit b5c66bab72a6a65edb15beb60b90d3cb84c5763b upstream. + +posix_acl_update_mode() could possibly clear 'acl', if so we leak the +memory pointed by 'acl'. Save this pointer before calling +posix_acl_update_mode() and release the memory if 'acl' really gets +cleared. + +Link: http://lkml.kernel.org/r/1486678332-2430-1-git-send-email-xiyou.wangcong@gmail.com +Signed-off-by: Cong Wang +Reported-by: Mark Salyzyn +Reviewed-by: Jan Kara +Reviewed-by: Greg Kurz +Cc: Eric Van Hensbergen +Cc: Ron Minnich +Cc: Latchesar Ionkov +Signed-off-by: Andrew Morton +Signed-off-by: Linus Torvalds +Signed-off-by: Greg Kroah-Hartman + +--- + fs/9p/acl.c | 2 ++ + 1 file changed, 2 insertions(+) + +--- a/fs/9p/acl.c ++++ b/fs/9p/acl.c +@@ -283,6 +283,7 @@ static int v9fs_xattr_set_acl(const stru + case ACL_TYPE_ACCESS: + if (acl) { + struct iattr iattr; ++ struct posix_acl *old_acl = acl; + + retval = posix_acl_update_mode(inode, &iattr.ia_mode, &acl); + if (retval) +@@ -293,6 +294,7 @@ static int v9fs_xattr_set_acl(const stru + * by the mode bits. So don't + * update ACL. + */ ++ posix_acl_release(old_acl); + value = NULL; + size = 0; + }