From: Tom de Vries Date: Sun, 24 Nov 2024 08:21:28 +0000 (+0100) Subject: opcodes: fix Werror=format build breaker in opcodes/riscv-dis.c X-Git-Tag: gdb-16-branchpoint~337 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=620651665318e9ac655c7fa189ee297e2bc02e97;p=thirdparty%2Fbinutils-gdb.git opcodes: fix Werror=format build breaker in opcodes/riscv-dis.c I build gdb on arm-linux and ran into: ... CC riscv-dis.lo opcodes/riscv-dis.c: In function ‘print_insn_args’: opcodes/riscv-dis.c:743:29: error: format ‘%lu’ expects argument of type \ ‘long unsigned int’, but argument 4 has type ‘insn_t’ \ {aka ‘long long unsigned int’} [-Werror=format=] 743 | "%lu", EXTRACT_ZCMT_INDEX (l)); | ~~^ | | | long unsigned int | %llu ... Fix this by printing the insn_t value, which is a uint64_t, using PRIu64. Tested by finishing the build. --- diff --git a/opcodes/riscv-dis.c b/opcodes/riscv-dis.c index 101380f93aa..c1212b14a05 100644 --- a/opcodes/riscv-dis.c +++ b/opcodes/riscv-dis.c @@ -740,7 +740,7 @@ print_insn_args (const char *oparg, insn_t l, bfd_vma pc, disassemble_info *info case 'i': case 'I': print (info->stream, dis_style_address_offset, - "%lu", EXTRACT_ZCMT_INDEX (l)); + "%" PRIu64, EXTRACT_ZCMT_INDEX (l)); break; default: goto undefined_modifier;