From: dklawren <dklawren@users.noreply.github.com>
Date: Mon, 28 Jan 2019 15:16:05 +0000 (-0500)
Subject: Bug 1523004 - Sort Phabricator revisions by numeric value instead of alphabetically
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=6254953071b85922bf1cd1abe2a45a63cca8933a;p=thirdparty%2Fbugzilla.git

Bug 1523004 - Sort Phabricator revisions by numeric value instead of alphabetically
---

diff --git a/extensions/PhabBugz/lib/WebService.pm b/extensions/PhabBugz/lib/WebService.pm
index d6480a601..9ecaff58b 100644
--- a/extensions/PhabBugz/lib/WebService.pm
+++ b/extensions/PhabBugz/lib/WebService.pm
@@ -172,6 +172,7 @@ sub bug_revisions {
     my $revision_obj  = Bugzilla::Extension::PhabBugz::Revision->new($revision);
     my $revision_data = {
       id          => 'D' . $revision_obj->id,
+      sortkey     => $revision_obj->id,
       author      => $revision_obj->author->name,
       status      => $revision_obj->status,
       long_status => $revision_status_map->{$revision_obj->status}
@@ -200,7 +201,7 @@ sub bug_revisions {
   }
 
   # sort by revision id
-  @revisions = sort { $a->{id} cmp $b->{id} } @revisions;
+  @revisions = sort { $a->{sortkey} <=> $b->{sortkey} } @revisions;
 
   return {revisions => \@revisions};
 }