From: Markus Armbruster Date: Thu, 10 Oct 2024 15:01:43 +0000 (+0200) Subject: hw/intc/openpic: Improve errors for out of bounds property values X-Git-Tag: v9.2.0-rc0~43^2~1 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=627c1e012cb3f14745f9b7d991642894a4402d5c;p=thirdparty%2Fqemu.git hw/intc/openpic: Improve errors for out of bounds property values The error message doesn't matter much, as the "openpic" device isn't user-creatable. But it's the last use of QERR_PROPERTY_VALUE_OUT_OF_RANGE, which has to go. Change the message just like the previous commit did for x86 CPUs. Signed-off-by: Markus Armbruster Message-ID: <20241010150144.986655-7-armbru@redhat.com> Reviewed-by: Daniel P. Berrangé Reviewed-by: Philippe Mathieu-Daudé --- diff --git a/hw/intc/openpic.c b/hw/intc/openpic.c index 32bd880dfa5..cd3d87768e0 100644 --- a/hw/intc/openpic.c +++ b/hw/intc/openpic.c @@ -41,7 +41,6 @@ #include "hw/pci/msi.h" #include "qapi/error.h" #include "qemu/bitops.h" -#include "qapi/qmp/qerror.h" #include "qemu/module.h" #include "qemu/timer.h" #include "qemu/error-report.h" @@ -1535,9 +1534,7 @@ static void openpic_realize(DeviceState *dev, Error **errp) }; if (opp->nb_cpus > MAX_CPU) { - error_setg(errp, QERR_PROPERTY_VALUE_OUT_OF_RANGE, - TYPE_OPENPIC, "nb_cpus", (uint64_t)opp->nb_cpus, - (uint64_t)0, (uint64_t)MAX_CPU); + error_setg(errp, "property 'nb_cpus' can be at most %d", MAX_CPU); return; }