From: Jim Meyering <meyering@redhat.com>
Date: Sat, 20 Mar 2010 11:14:46 +0000 (+0100)
Subject: maint: enforce one small aspect of formatting style: space-before-"("
X-Git-Tag: v8.5~41
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=628a5e16ddd28110c506f34667ef993d9be7b837;p=thirdparty%2Fcoreutils.git

maint: enforce one small aspect of formatting style: space-before-"("

* cfg.mk (sc_space_before_open_paren): New rule.
---

diff --git a/cfg.mk b/cfg.mk
index 71f3d85a4b..8a6adc2a92 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -261,6 +261,29 @@ sc_prohibit_sleep:
 	msg='prefer xnanosleep over other sleep interfaces'		\
 	  $(_prohibit_regexp)
 
+_space_before_paren_exempt =? \\n\\$$
+_space_before_paren_exempt = \
+  (\\n\\$$|%s\(to %s|delimit-method|(date|group|character)\(s\))
+# Ensure that there is a space before each open parenthesis in C code.
+sc_space_before_open_paren:
+	@if $(VC_LIST_EXCEPT) | grep -l '\.[ch]$$' > /dev/null; then	\
+	  if (cpp -fpreprocessed < /dev/null > /dev/null 2>&1); then	\
+	    fail=0;							\
+	    for c in $$($(VC_LIST_EXCEPT) | grep '\.[ch]$$'); do	\
+	      cpp -fpreprocessed $$c 2>/dev/null			\
+		| grep -ni '[[:alnum:]]('				\
+		| grep -vE '$(_space_before_paren_exempt)'		\
+		| grep . && { fail=1; echo "*** $$c"; };		\
+	    done;							\
+	    test $$fail = 1 &&						\
+	      { echo '$(ME): the above files lack a space-before-open-paren' \
+		  1>&2; exit 1; } || :;					\
+	  else								\
+	    echo '$(ME): skipping test $@: cppi not installed' 1>&2;	\
+	  fi;								\
+	else :;								\
+	fi
+
 include $(srcdir)/dist-check.mk
 
 update-copyright-env = \