From: Mark Wielaard <mark@klomp.org>
Date: Tue, 30 Apr 2019 18:48:13 +0000 (+0200)
Subject: tests: Don't printf a known NULL symname in backtrace-dwarf.c.
X-Git-Tag: elfutils-0.177~19
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=62bed2018232379ac91020137df37afe5e6a5579;p=thirdparty%2Felfutils.git

tests: Don't printf a known NULL symname in backtrace-dwarf.c.

GCC9 on 32bit systems might warn about '%s' directive argument is null
for symname in backtrace-dwarf.c. Just check whether symname is NULL.

This is an identical fix for the same issue as found in backtrace.c,
but now in backtrace-dwarf.c

Signed-off-by: Mark Wielaard <mark@klomp.org>
---

diff --git a/tests/ChangeLog b/tests/ChangeLog
index a4f5dd3ed..d6dafa467 100644
--- a/tests/ChangeLog
+++ b/tests/ChangeLog
@@ -1,3 +1,8 @@
+2019-04-30  Mark Wielaard  <mark@klomp.org>
+
+	* backtrace-dwarf.c (frame_callback): Explicitly check symname is
+	NULL.
+
 2019-04-30  Mark Wielaard  <mark@klomp.org>
 
 	* backtrace.c (frame_callback): Explicitly check symname is NULL.
diff --git a/tests/backtrace-dwarf.c b/tests/backtrace-dwarf.c
index dfbf1856b..f446bc3b4 100644
--- a/tests/backtrace-dwarf.c
+++ b/tests/backtrace-dwarf.c
@@ -101,7 +101,7 @@ frame_callback (Dwfl_Frame *state, void *frame_arg)
   if (mod)
     symname = dwfl_module_addrname (mod, pc_adjusted);
 
-  printf ("%#" PRIx64 "\t%s\n", (uint64_t) pc, symname);
+  printf ("%#" PRIx64 "\t%s\n", (uint64_t) pc, symname ?: "<null>");
 
   if (symname && (strcmp (symname, "main") == 0
 		  || strcmp (symname, ".main") == 0))