From: Peter Krempa <pkrempa@redhat.com>
Date: Wed, 2 Apr 2025 07:45:19 +0000 (+0200)
Subject: qemu: domain: Don't check return value of 'virCPUDefCopy'
X-Git-Tag: v11.3.0-rc1~90
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=62d67948270a0d44ccfe5675547cfa4d9e77bb4a;p=thirdparty%2Flibvirt.git

qemu: domain: Don't check return value of 'virCPUDefCopy'

As 'virCPUDefCopy' can't fail any more (without aborting) remove the
last two return value checks.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index e45eef4787..c3ca4b3040 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
@@ -5321,8 +5321,7 @@ qemuDomainDefFormatBufInternal(virQEMUDriver *driver,
          */
         if (origCPU) {
             virCPUDefFree(def->cpu);
-            if (!(def->cpu = virCPUDefCopy(origCPU)))
-                return -1;
+            def->cpu = virCPUDefCopy(origCPU);
         }
 
         if (def->cpu &&
@@ -9354,8 +9353,8 @@ qemuDomainSaveCookieNew(virDomainObj *vm)
     if (!(cookie = virObjectNew(qemuDomainSaveCookieClass)))
         return NULL;
 
-    if (priv->origCPU && !(cookie->cpu = virCPUDefCopy(vm->def->cpu)))
-        return NULL;
+    if (priv->origCPU)
+        cookie->cpu = virCPUDefCopy(vm->def->cpu);
 
     cookie->slirpHelper = qemuDomainGetSlirpHelperOk(vm);